This repository was archived by the owner on Nov 27, 2020. It is now read-only.
Display a directory separator adapted to the OS Symfony is running on #991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alsciende
changed the title
| 'base_dir' => realpath($this->getParameter('kernel.root_dir').'/..'), | ||
| ]); | ||
| return $this->render('default/index.html.twig', array( | ||
| 'base_dir' => realpath($this->getParameter('kernel.root_dir').'/..').DIRECTORY_SEPARATOR, |
There was a problem hiding this comment.
But why you missing directory separator in '/..'?
There was a problem hiding this comment.
This one is parsed by realpath, which returns only \ on Windows.
|
👍 |
|
Is this PR ignored because of the failing check? |
|
@alsciende No, merging just takes some time. And because other developers could be able to give their opinion (pros and cons) about these changes as well. |
|
Thank you @alsciende. |
fabpot
added a commit
that referenced
this pull request
Sep 6, 2016
… running on (Alsciende) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #991). Discussion ---------- Display a directory separator adapted to the OS Symfony is running on On Windows, the current Symfony installer displays > Your application is now ready. You can start working on it at: and a path followed by `/`, even though the path itself (returned by `realpath`) is separated by `\`. It is inelegant et potentially confusing. This PR tries to fix that. Commits ------- 8643373 Display a directory separator adapted to the OS Symfony is running on
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, the current Symfony installer displays
and a path followed by
/, even though the path itself (returned byrealpath) is separated by\. It is inelegant et potentially confusing.This PR tries to fix that.